arpadboda commented on a change in pull request #465: MINIFICPP-700: Add MSI
Support via CPACK
URL: https://github.com/apache/nifi-minifi-cpp/pull/465#discussion_r245267979
##########
File path: CMakeLists.txt
##########
@@ -199,7 +199,11 @@ if(USE_SYSTEM_ZLIB STREQUAL "OFF")
message("Using bundled zlib")
if (WIN32)
+ if (CMAKE_BUILD_TYPE MATCHES RelWithDebInfo OR CMAKE_BUILD_TYPE MATCHES
Release)
Review comment:
What's wrong with the previous approach, which used build type == debug?
With a quick grep I found only these 3 valid values (RelWithDebInfo,
Release, Debug)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
