arpadboda commented on a change in pull request #465: MINIFICPP-700: Add MSI
Support via CPACK
URL: https://github.com/apache/nifi-minifi-cpp/pull/465#discussion_r245268378
##########
File path: nanofi/examples/CMakeLists.txt
##########
@@ -57,6 +57,8 @@ else ()
set(LINK_END_FLAGS "")
endif ()
+if (NOT WIN32)
Review comment:
That means we don't compile nanofi examples for Win at all.
If that's the goal, I would prefer having the Win-specific flags
(Wholearchive) removed, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
