mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop &
Configure" button functionality to Processor…
URL: https://github.com/apache/nifi/pull/3281#discussion_r252843357
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
##########
@@ -274,6 +280,82 @@
}
}];
+ // determine if we should show the Stop & Configure button
+ if (top === window &&
+ nfCommon.isDefinedAndNotNull(processor.state) &&
+ nfCommon.isDefinedAndNotNull(processorResponse.uri) &&
+ nfCommon.isDefinedAndNotNull(nfProcessor) &&
+ nfCommon.isDefinedAndNotNull(nfProcessorConfiguration)
) {
+
+ //Add in the Stop & Configure button
+ buttons.splice(1,0,{
+ buttonText: ' Stop & Configure',
+ clazz: 'fa fa-stop button-icon auto-width',
+ color: {
+ base: '#E3E8EB',
+ hover: '#C7D2D7',
+ text: '#813131'
+ },
+ disabled : function(){
+ return !( processor.state == "RUNNING" &&
+ (processorResponse.permissions.canWrite ||
+
processorResponse.operatePermissions.canWrite) );
+ },
+ handler: {
+ click: function () {
Review comment:
Rather than having the logic included within `nf-processor-details` which
requires `nfProcessor` and `nfProcessorConfiguration`, what do you think about
possibly passing in some configuration object into
`nfProcessorDetails.init(...)` which could contain a callback to hold this
logic?
In doing so, I _think_ we'd be able to move this logic to `nfActions` or
something and reference it when initializing `nfProcessorDetails` in the
canvas. When initializing `nfProcessorDetails` in summary we could omit this
configuration object the presence of which could be the condition under which
we show this button.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
