mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop &
Configure" button functionality to Processor…
URL: https://github.com/apache/nifi/pull/3281#discussion_r252841292
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
##########
@@ -37,17 +39,21 @@
require('nf.Dialog'),
require('nf.ErrorHandler'),
require('nf.CustomUi'),
- require('nf.ClusterSummary')));
+ require('nf.ClusterSummary'),
+ require('nf.Processor'),
+ require('nf.ProcessorConfiguration')));
} else {
nf.ProcessorDetails = factory(root.$,
root.nf.Common,
root.nf.UniversalCapture,
root.nf.Dialog,
root.nf.ErrorHandler,
root.nf.CustomUi,
- root.nf.ClusterSummary);
+ root.nf.ClusterSummary,
+ root.nf.Processor,
+ root.nf.ProcessorConfiguration);
}
-}(this, function ($, nfCommon, nfUniversalCapture, nfDialog, nfErrorHandler,
nfCustomUi, nfClusterSummary) {
+}(this, function ($, nfCommon, nfUniversalCapture, nfDialog, nfErrorHandler,
nfCustomUi, nfClusterSummary,nfProcessor,nfProcessorConfiguration) {
Review comment:
I'm not sure we can establish dependencies on `nfProcessor` and
`nfProcessorConfiguration` here. These dependencies are not available in all
usages of `nf-processor-details.js`. This may work successfully as-is, but that
is a consequence of not employing a module loader yet. We do in other codebases
(like nifi-registry) and plan to introduce here. Utilizing a module loader, I
believe this would fail.
Because we utilize the processor details in many contexts, we've tried to
keep the dependencies as few as possible. We can still introduce these changes,
but I think we may need to relocate the logic a bit. See my comments below for
a possible option, but I'm open to other suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
