alopresto commented on a change in pull request #3340: NIFI-6026 - First commit
which adds a new tls-toolkit mode called Key…
URL: https://github.com/apache/nifi/pull/3340#discussion_r260915121
##########
File path:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/standalone/TlsToolkitStandaloneCommandLine.java
##########
@@ -122,12 +129,25 @@ public static void main(String[] args) {
} catch (CommandLineParseException e) {
System.exit(e.getExitCode().ordinal());
}
- try {
- new
TlsToolkitStandalone().createNifiKeystoresAndTrustStores(tlsToolkitStandaloneCommandLine.createConfig());
- } catch (Exception e) {
- tlsToolkitStandaloneCommandLine.printUsage("Error generating TLS
configuration. (" + e.getMessage() + ")");
- System.exit(ExitCode.ERROR_GENERATING_CONFIG.ordinal());
+
+ StandaloneConfig conf =
tlsToolkitStandaloneCommandLine.createSplitKeystoreConfig();
Review comment:
I think it makes sense to check `isSplitKeystore` before creating this
config object because currently this is always created whether it is needed or
not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
