alopresto commented on a change in pull request #3340: NIFI-6026 - First commit
which adds a new tls-toolkit mode called Key…
URL: https://github.com/apache/nifi/pull/3340#discussion_r260915484
##########
File path:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/standalone/TlsToolkitStandaloneCommandLine.java
##########
@@ -168,6 +188,17 @@ protected CommandLine doParse(String... args) throws
CommandLineParseException {
clientPasswordsGenerated =
commandLine.getOptionValues(CLIENT_CERT_PASSWORD_ARG) == null;
overwrite = commandLine.hasOption(OVERWRITE_ARG);
+ if(commandLine.hasOption(SPLIT_KEYSTORE_ARG)) {
+ if(commandLine.hasOption(KEY_STORE_PASSWORD_ARG) &&
commandLine.hasOption(KEY_PASSWORD_ARG)) {
Review comment:
I think `KEY_PASSWORD_ARG` can legitimately be empty if the keystore
password and key password are the same (i.e. no explicit key password was set).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
