[GitHub] R-Bower edited a comment on issue #3335: NIFI-5018

[GitBox]

R-Bower edited a comment on issue #3335: NIFI-5018
URL: https://github.com/apache/nifi/pull/3335#issuecomment-468410297
 
 
   Here are the size changes that I've made for this feature:
   ```
        var portDimensions = {
            width: 240,
   -        height: 50
   +        height: 48
        };
        var remotePortDimensions = {
            width: 240,
   -        height: 75
   +        height: 80
        };
   // process-group
        var dimensions = {
   -        width: 380,
   -        height: 172
   +        width: 384,
   +        height: 176
        };
   
   // remote process group
        var dimensions = {
   -        width: 380,
   -        height: 158
   +        width: 384,
   +        height: 176
        };
   ```
   
   Luckily, I didn't have to make drastic changes to accommodate the 8-pixel 
snap alignment.  The most drastic shift is clearly the Remote Process Group's 
height.  I scrolled in a bit to get a closer look (you can ignore the border 
artifacts - they're from my screenshot utility):
   
   Before:
   
![image](https://user-images.githubusercontent.com/11933208/53594122-65f10a80-3b57-11e9-8338-528c26443b2c.png)
   
   After:
   
![image](https://user-images.githubusercontent.com/11933208/53594110-5f629300-3b57-11e9-9384-d5001006eb7b.png)
   
   I think this change warrants a slight adjustment.  The others probably don't 
need any modifications.
   
   Here's the Process Group component, before and after:
   
   Before:
   
![image](https://user-images.githubusercontent.com/11933208/53594208-9afd5d00-3b57-11e9-9233-b69200781927.png)
   
   After:
   
![image](https://user-images.githubusercontent.com/11933208/53594215-9e90e400-3b57-11e9-8282-259faea8048e.png)
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services