ijokarumawak commented on a change in pull request #3351: NIFI-2933 Remote
input/output ports at any PG
URL: https://github.com/apache/nifi/pull/3351#discussion_r266735456
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/new-port-dialog.jsp
##########
@@ -23,5 +23,16 @@
<input id="new-port-name" type="text"/>
</div>
</div>
+ <div class="setting">
Review comment:
Made the dialog larger. So there's no scrolling border. Also hide the combo
on the root group.
I also wanted to change the dialog size on the root group or on child
groups, however, dialog elements `height` and `min-highet` are updated
automatically (I assume JQuery does that). I gave up changing the dialog size.
There are unnecessary space if the dialog is shown on the root group. I hope
it's still acceptable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
