ijokarumawak commented on a change in pull request #3351: NIFI-2933 Remote 
input/output ports at any PG
URL: https://github.com/apache/nifi/pull/3351#discussion_r269446817
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java
 ##########
 @@ -3301,6 +3307,33 @@ public Response instantiateTemplate(
         );
     }
 
+    private void verifyPublicPortUniqueness(FlowSnippetDTO snippet) {
+        snippet.getInputPorts().stream().filter(portDTO -> 
Boolean.TRUE.equals(portDTO.isAllowRemoteAccess()))
 
 Review comment:
   Yeah, but it produces NullPointerException when the value is null. The 
intent of using non primitive type was accepting client requests without having 
this field. DTO usually doesn't have value if the REST client didn't intended 
to update or set.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to