mcgilman commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor… URL: https://github.com/apache/nifi/pull/3281#issuecomment-474533126 @aeaversa Thanks for the updates. Good work here. A few more comments on the behavior. I haven't had a chance to dig in yet but want to share some initial thoughts. - I think the `Stop & Configure` menu item should be available when the component is stopped but there are active threads. This is most easily testable using `DebugFlow` and setting the `On Trigger Pause Time`. Should this menu item be visible under the same conditions as the `View configuration` menu item? - Should the status bar be visible when it's unneeded? - Quickly looking at the changes introduced into the jquery dialog component, I'm wondering if we should decouple the status bar content so that there's no dialog instance specific things in there. The fact that we're rendering component status, threads, and bulletins there are very specific to this use case and probably shouldn't be in the generic dialog component. What if we wanted to take this approach with other dialogs and other components that may report status differently (like active transmission for remote ports)? The fact that the button model is configurable is great. @moranr Any thoughts? Icon for the `Stop & Configure` menu item look good?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
