mcgilman commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor… URL: https://github.com/apache/nifi/pull/3281#issuecomment-476781200 I think the confusion here is stemming from the original JIRA and the comments on the motivation for the change above. The issue as described was that we have a Processor running someplace. Upon viewing the Processor Details, the user realizes they need to update some configuration and the process to do so is extremely cumbersome. I can see why @moranr was surprised by its addition of a new menu item. I was also thrown off by it a little bit which is why I wanted to make sure @moranr could review it. If we are considering a case where the Processor is running and the user wants to configure it (not from the Processor Details dialog) I would suggest we take a combined approach. The user would still select the Stop menu item from the context menu as they would today. From there we could immediately show the Configure menu item even if there are active threads since we won't activate the Apply button until those threads complete. @aeaversa I can understand the code duplication concern with extracting the run state, threads, and bulletins out of the dialog. However, I think you should be able to create some utility function that Processors can utilize which can return some general type (maybe a jQuery instance) so we don't need that type of business logic within the dialog widget itself.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
