aeaversa commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor… URL: https://github.com/apache/nifi/pull/3281#issuecomment-474793462 @mcgilman - Thanks again for the great feedback! - As far as the "Stop & Configure" being persisted in the context menu, I do see where you are going, but think a clearer approach may be to simply modify the "View Configuration" to prompt as "Configure" when a processor is in a stopped state with active threads. I say this because the processor is already displaying the "Stopped" icon even when it has active threads and seeing a "Stop & Configure" button persisting probably would lead the user to think their prior "Stop & Configure" action was not successful. Thoughts? - As far as the status bar being visible when its not needed, the feedback I've gathered from users has been pretty consistent in that when opened, the configuration dialog window tends to overlay the processor element on the graph and thus prevent the user from knowing the current state [ie- Started/Stopped/Invalid/Validating/Disabled]. The current implementation covers all states the processor could potentially achieve in the status bar and I can't see the harm in continuing to provide that state visualization. Thoughts? - Lastly, I do see your point on not having the status bar as part of the jquery.modal component. I too wasn't a fan of putting it there, but I placed the logic there in order to avoid replicating code across the two dialog windows as it was a common point to both that I could leverage the button model logic already present. I will take a look at it and see if I can decouple that further to be more generic.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
