aeaversa commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor… URL: https://github.com/apache/nifi/pull/3281#issuecomment-475198401 > > I think it is flawed logic to rely on the status bar being "new" as an indicator the wording/button is a clickable object. It won't be "new" forever, and it should be just as obvious to a first-time user. > > @markobean I agree. I didn't mean to express the idea that something new would indicate something is clickable. My point was that visually the status bar, as a whole, is new. Someone seeing it for the first time would likely be curious about each part of it. Evaluating the appearance of the text alone is what I think indicates it's clickable. It is styled like other links in the app and similar to a button in font size/color/case treatment. > > > The icon on the Stop & Configure in the status bar is the only thing I'm 50/50 on. If the icon stays, it has to remain as the fa-pencil-square to be consistent with the context menu since the gear already exists in this menu. > > If I'm following the discussion by @mcgilman and @aeaversa correctly, we may only see a 'Stop & Configure' labeled action from the dialog with the new status bar. The context menu action will continue to say 'Configure' because it is stopped (even though active threads exist). @moranr - Actually, I think we are still keeping the "Stop & Configure" context menu entry. The main objective of the feature was seeking was to provide a more direct path for the user that allows them to edit a processor's properties, and having that direct option in the context menu i would say is super important. I think @mcgilman was just pointing out the fact that in the change the "View Configuration" menu option needs to be updated to "Configuration" when a processor is in a stopped state with active threads, since now the Processor Configuration modal will simply disable the Apply button and provide the user a Terminate button in the status bar should the user wish to apply their changes quickly. @mcgilman Let me know if I understood you correctly on that. I am not married to the pencil-square icon, but it does seem that all the context menu items all have an icon, so I'm open to suggestions. :-) Thanks to everyone for all the great feedback.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
