arpadboda commented on a change in pull request #533: MINIFICPP-726 - Enhance ExtractText to have more feature parity with … URL: https://github.com/apache/nifi-minifi-cpp/pull/533#discussion_r274344717
########## File path: libminifi/src/processors/ExtractText.cpp ########## @@ -21,6 +21,7 @@ #include <string> #include <memory> #include <set> +#include <regex> Review comment: Regex support was added in gcc4.9, u16 uses 5.3, so that's more than fine, u14 although uses 4.8, so yes, it's not gonna work. The question here is urgency: if we need it out pretty soon, I naturally do it. In case we don't, u14 is EOL at the end of this month (so is gcc4.8 for a while), so I don't think we are going to support it for long, most probably not with 1.0. In this case it can wait. I'm happy with both options, what's your opinion? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
