arpadboda commented on a change in pull request #533: MINIFICPP-726 - Enhance
ExtractText to have more feature parity with …
URL: https://github.com/apache/nifi-minifi-cpp/pull/533#discussion_r274958921
##########
File path: libminifi/src/processors/ExtractText.cpp
##########
@@ -74,11 +111,13 @@ void ExtractText::onTrigger(core::ProcessContext
*context, core::ProcessSession
int64_t ExtractText::ReadCallback::process(std::shared_ptr<io::BaseStream>
stream) {
int64_t ret = 0;
uint64_t read_size = 0;
+ bool regex_mode = RegexMode.getDefaultValue();
Review comment:
Maybe the fact I'm a bit afraid of is the scenario when the property is not
required and neither have a default value, so getProperty might return no
value.
In this case it can't occur unless someone removes the defaults, so I
removed them here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
