arpadboda commented on a change in pull request #549: MINIFICPP-835: Import
libressl differently and attempt to link in windows.
URL: https://github.com/apache/nifi-minifi-cpp/pull/549#discussion_r281653007
##########
File path: main/CMakeLists.txt
##########
@@ -118,6 +123,13 @@ if (WIN32)
target_link_libraries(minifiexe semaphore)
endif()
+if (NOT USE_SHARED_LIBS)
Review comment:
Doesn't really matter, just readibility: why not using an AND here instead
of nested conditions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
