arpadboda commented on a change in pull request #548: MINIFICPP-831- Remove
debug target and change to relwithdebinfo
URL: https://github.com/apache/nifi-minifi-cpp/pull/548#discussion_r281658090
##########
File path: CMakeSettings.json
##########
@@ -85,7 +97,7 @@
{
"name": "x64-Release",
"generator": "Ninja",
- "configurationType": "RelWithDebInfo",
+ "configurationType": "Release",
Review comment:
Are you sure?
As far as I understand (fixme) our previous releases were built with
DebInfo, which now goes away.
At first look this makes sense for me, too, although I think this sacrifices
the possibility of getting stack traces in case of production support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
