arpadboda commented on a change in pull request #584: minificpp-773 URL: https://github.com/apache/nifi-minifi-cpp/pull/584#discussion_r290655764
########## File path: extensions/windows-event-log/ConsumeWindowsEventLog.h ########## @@ -79,6 +81,8 @@ class ConsumeWindowsEventLog : public core::Processor void unsubscribe(); int processQueue(const std::shared_ptr<core::ProcessSession> &session); + void createTextOutput(std::wstringstream& strStream, MSXML2::IXMLDOMElementPtr pRoot, std::vector<std::wstring>& listTag); Review comment: Could you make the pRoot param first and const, too? The only thing I would like to achieve by this is the signature clearly differentiating in and out params. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
