arpadboda commented on a change in pull request #584: minificpp-773
URL: https://github.com/apache/nifi-minifi-cpp/pull/584#discussion_r290659228
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -134,14 +157,81 @@ void ConsumeWindowsEventLog::onTrigger(const
std::shared_ptr<core::ProcessContex
}
}
-bool ConsumeWindowsEventLog::subscribe(const
std::shared_ptr<core::ProcessContext> &context)
-{
+void ConsumeWindowsEventLog::createTextOutput(std::wstringstream& stream,
MSXML2::IXMLDOMElementPtr pRoot, std::vector<std::wstring>& ancestors) {
+ const auto pNodeChildren = pRoot->childNodes;
+
+ auto writeAncestors = [](std::wstringstream& stream,
std::vector<std::wstring>& ancestors) {
+ for (size_t j = 0; j < ancestors.size() - 1; j++) {
+ stream << ancestors[j] + L'/';
+ }
+ stream << ancestors[ancestors.size() - 1];
Review comment:
Vector has "back()" function to avoid this, but it's only nitpicking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
