phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r295777425
##########
File path: extensions/expression-language/tests/ExpressionLanguageTests.cpp
##########
@@ -187,13 +195,13 @@ TEST_CASE("GetFile PutFile dynamic attribute",
"[expressionLanguageTestGetFilePu
auto repo = std::make_shared<TestRepository>();
std::string in_dir("/tmp/gt.XXXXXX");
- REQUIRE(testController.createTempDirectory(&in_dir[0]) != nullptr);
+ REQUIRE(!testController.createTempDirectory(&in_dir[0]).empty());
Review comment:
This doesn't serve a great deal of purpose. we should be using the temp dirs
not just throwing them away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
