phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r295777839
 
 

 ##########
 File path: extensions/http-curl/tests/C2VerifyHeartbeatAndStop.cpp
 ##########
 @@ -63,7 +63,7 @@ class Responder : public CivetHandler {
     std::string response;
     int blockSize = 1024 * sizeof(char), readBytes;
 
-    char buffer[blockSize];
+    char buffer[1024];
 
 Review comment:
   Windows pointed this out. No point in keeping blockSize around. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to