alopresto commented on a change in pull request #3542: NIFI-6363 Integrates AWS
KMS SPP. Refactors SSPP.
URL: https://github.com/apache/nifi/pull/3542#discussion_r296364540
##########
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy
##########
@@ -1043,12 +1050,12 @@ class ConfigEncryptionTool {
* @param plainProperties the NiFiProperties instance containing the raw
values
* @return the NiFiProperties containing protected values
*/
- private NiFiProperties encryptSensitiveProperties(NiFiProperties
plainProperties) {
+ private NiFiProperties encryptSensitiveProperties(NiFiProperties
plainProperties, String keyHex) {
Review comment:
Rename `keyHex` to `keyHexOrKeyId` to indicate this can support AWS KMS as
well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services