alopresto commented on a change in pull request #3542: NIFI-6363 Integrates AWS
KMS SPP. Refactors SSPP.
URL: https://github.com/apache/nifi/pull/3542#discussion_r296367647
##########
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy
##########
@@ -1568,7 +1572,7 @@ class ConfigEncryptionTool {
// If the tool is not going to encrypt NiFiProperties
and the existing file is already encrypted, encrypt and update the new
sensitive props key
if (!tool.handlingNiFiProperties &&
existingNiFiPropertiesAreEncrypted) {
- AESSensitivePropertyProvider spp = new
AESSensitivePropertyProvider(tool.keyHex)
+ SensitivePropertyProvider spp =
StandardSensitivePropertyProvider.fromKey(tool.keyHex)
Review comment:
The field `tool.keyHex` probably needs to be re-examined as it is no longer
_just_ the AES key. When the internal logic was written, it was designed with
extensibility, but this tool was written as a helper script and not designed
for the injection of the provider. This should be re-evaluated due to the
introduction of the AWS KMS provider. (Another subtask).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
