phrocker commented on a change in pull request #596: MINIFICPP-925 - Fix
TailFile hang on long lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/596#discussion_r296846295
##########
File path: extensions/standard-processors/processors/TailFile.cpp
##########
@@ -66,7 +66,8 @@ core::Property TailFile::StateFile("State File", "Specifies
the file that should
" what data has been ingested so that upon
restart NiFi can resume from where it left off",
"TailFileState");
core::Property TailFile::Delimiter("Input Delimiter", "Specifies the character
that should be used for delimiting the data being tailed"
Review comment:
If a delimiter isn't specified we should consider this an error if we're
using a delimiter mode OR assume newline..... I would suggest adding an for
mode with two allowable values of delimiter and size based.
If size is being used we can have that specified and make this property an
error condition. we should separate those ideologies entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
