phrocker commented on a change in pull request #596: MINIFICPP-925 - Fix
TailFile hang on long lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/596#discussion_r296838715
##########
File path:
extensions/standard-processors/tests/integration/TailFileCronTest.cpp
##########
@@ -73,7 +73,7 @@ class TailFileTestHarness : public IntegrationBase {
virtual void runAssertions() {
assert(LogTestController::getInstance().contains("5 flowfiles were
received from TailFile input") == true);
assert(LogTestController::getInstance().contains("Looking for delimiter
0xA") == true);
- assert(LogTestController::getInstance().contains("li\\ne5") == true);
+
assert(LogTestController::getInstance().contains(utils::StringUtils::to_hex("li\\ne5"))
== true);
Review comment:
Was that test assertion looking for a non-delimited line? If so why the need
for to_hex?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
