natural commented on a change in pull request #3542: NIFI-6363 Integrates AWS
KMS SPP. Refactors SSPP.
URL: https://github.com/apache/nifi/pull/3542#discussion_r296872715
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/test/groovy/org/apache/nifi/properties/ProtectedNiFiPropertiesGroovyTest.groovy
##########
@@ -77,7 +83,7 @@ class ProtectedNiFiPropertiesGroovyTest extends
GroovyTestCase {
}
}
- private static ProtectedNiFiProperties loadFromFile(String
propertiesFilePath) {
+ private static ProtectedNiFiProperties loadFromFile(String
propertiesFilePath, String defaultKeyHex) {
Review comment:
I did this in two steps:
1. Replaced all of the string parameters to the `ProtectedNiFiProperties`
ctors and factory methods with `SensitivePropertyProvider` parameters.
Adjusted all call sites with new parameter instances.
2. Added new ctors and factory method signatures to support passing strings
as keys. These methods construct the `StandardSensitivePropertyProvider`
instance just like the client code was doing, no keys or references to keys are
saved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
