natural commented on a change in pull request #3542: NIFI-6363 Integrates AWS
KMS SPP. Refactors SSPP.
URL: https://github.com/apache/nifi/pull/3542#discussion_r296880952
##########
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy
##########
@@ -1269,10 +1273,10 @@ class ConfigEncryptionTool {
}
private
- static List<String>
serializeNiFiPropertiesAndPreserveFormat(NiFiProperties niFiProperties, File
originalPropertiesFile) {
+ static List<String>
serializeNiFiPropertiesAndPreserveFormat(NiFiProperties niFiProperties, File
originalPropertiesFile, String keyHex) {
Review comment:
When I first refactored the String keys into `SensitivePropertyProvider`
instances, it made sense to adjust the method signatures. However, after
reviewing the net change, most of the calls seemed like they had been over
complicated with little to no benefit to the caller.
So I re-re-factored (as I mentioned above) to allow clients to pass in
string keys. In all of those cases, the client was still maintaining the
string key anyway, so it's not as if we've added any new un-protected key usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
