natural commented on a change in pull request #3542: NIFI-6363 Integrates AWS
KMS SPP. Refactors SSPP.
URL: https://github.com/apache/nifi/pull/3542#discussion_r297332886
##########
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy
##########
@@ -1568,7 +1572,7 @@ class ConfigEncryptionTool {
// If the tool is not going to encrypt NiFiProperties
and the existing file is already encrypted, encrypt and update the new
sensitive props key
if (!tool.handlingNiFiProperties &&
existingNiFiPropertiesAreEncrypted) {
- AESSensitivePropertyProvider spp = new
AESSensitivePropertyProvider(tool.keyHex)
+ SensitivePropertyProvider spp =
StandardSensitivePropertyProvider.fromKey(tool.keyHex)
Review comment:
I renamed `keyHex` to `keyOrKeyId` and `migrationKeyHex` to
`migrationKeyOrKeyId`. Similarly adjusted method parameter names, and various
variable names in the class.
However, when I tried to rename either of the methods `getKey` and
`getMigrationKey`, the tests hang. Not sure where the behavior is coming from;
even adding (not renaming) a similar method produces the hangs.
There is still plenty of internal hex-string handling, and I'll revisit
those as time allows. If we still can't resolve all of that, I'll open that
secondary jira ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
