bakaid commented on a change in pull request #604: MINIFICPP-926 Create nanofi tailfile processor for tailing file by configurable chunk size URL: https://github.com/apache/nifi-minifi-cpp/pull/604#discussion_r300614504
########## File path: nanofi/src/api/ecu.c ########## @@ -0,0 +1,130 @@ + +#include "api/ecu.h" +#include "api/nanofi.h" +#include "core/string_utils.h" +#include "core/cstructs.h" +#include "core/file_utils.h" +#include "core/flowfiles.h" +#include <unistd.h> +#include <stdlib.h> +#include <stdio.h> +#include <string.h> +#include <errno.h> +#include <limits.h> +#include <signal.h> +#include <sys/stat.h> + +nifi_instance * instance = NULL; +standalone_processor * proc = NULL; +flow_file_list ff_list; +int curr_offset = 0; Review comment: This will eventually overflow for files larger than ~2GB, which is not an unreasonable use case. I think it should be uint64_t. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
