bakaid commented on a change in pull request #604: MINIFICPP-926 Create nanofi tailfile processor for tailing file by configurable chunk size URL: https://github.com/apache/nifi-minifi-cpp/pull/604#discussion_r300620014
########## File path: nanofi/src/core/file_utils.c ########## @@ -0,0 +1,171 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include <stdlib.h> +#include <stdio.h> +#include <string.h> +#include <errno.h> +#include <unistd.h> +#include <sys/stat.h> +#include <dirent.h> + +#include "api/nanofi.h" +#include "api/ecu.h" +#include "core/string_utils.h" +#include "core/file_utils.h" + +flow_file_info log_aggregate(const char * file_path, char delim, int curr_offset, nifi_instance * instance, standalone_processor * proc) { + flow_file_info ff_info; + memset(&ff_info, 0, sizeof(ff_info)); + + if (!file_path) { + return ff_info; + } + + char buff[MAX_BYTES_READ + 1]; + memset(buff, 0, MAX_BYTES_READ+1); Review comment: There is no need to null this buffer, we use the size returned by fread to determine how many useful bytes are in there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
