apiri commented on a change in pull request #158: MINIFI-478 Fix broken
OrderedProperties and OrderedPropertiesTest
URL: https://github.com/apache/nifi-minifi/pull/158#discussion_r302184090
##########
File path:
minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/util/OrderedPropertiesTest.java
##########
@@ -36,20 +36,26 @@ public void testOrderedProperties() throws IOException {
orderedProperties.setProperty("prop1", "origVal1");
orderedProperties.setProperty("prop2", "val2", "#this is property 2");
orderedProperties.setProperty("prop3", "val3");
+ orderedProperties.setProperty("prop4", "val4");
+ orderedProperties.setProperty("prop5", "val5", "#this is property 5");
+ orderedProperties.setProperty("prop3", "newVal3");
orderedProperties.setProperty("prop1", "newVal1");
ByteArrayOutputStream byteArrayOutputStream = new
ByteArrayOutputStream();
orderedProperties.store(byteArrayOutputStream,
PROPERTIES_FILE_APACHE_2_0_LICENSE);
- try (BufferedReader bufferedReader = new BufferedReader(new
InputStreamReader(new
ByteArrayInputStream(byteArrayOutputStream.toByteArray())));
+ try (BufferedReader actualReader = new BufferedReader(new
InputStreamReader(new
ByteArrayInputStream(byteArrayOutputStream.toByteArray())));
BufferedReader expectedReader = new BufferedReader(new
InputStreamReader(OrderedPropertiesTest.class.getClassLoader().getResourceAsStream("orderedPropertiesExpected.properties"))))
{
String expectedLine;
while((expectedLine = expectedReader.readLine()) != null) {
- String actualLine = bufferedReader.readLine();
+ String actualLine = actualReader.readLine();
+ // assertEquals(expectedLine, actualLine);
Review comment:
should remove this errant comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
