bakaid commented on a change in pull request #610: MINIFICPP-814 - Fixed 
ListenHTTP and HTTPClient bugs, created tests f…
URL: https://github.com/apache/nifi-minifi-cpp/pull/610#discussion_r302966283
 
 

 ##########
 File path: extensions/http-curl/client/HTTPClient.cpp
 ##########
 @@ -120,8 +120,21 @@ void HTTPClient::forceClose() {
 
 }
 
+int HTTPClient::debug_callback(CURL *handle, curl_infotype type, char *data, 
size_t size, void *userptr) {
 
 Review comment:
   I think its much better to log this properly when setVerbose is used, 
instead of it just going to stderr, but if there is a reason for that I would 
be willing to discuss this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to