bakaid commented on a change in pull request #610: MINIFICPP-814 - Fixed
ListenHTTP and HTTPClient bugs, created tests f…
URL: https://github.com/apache/nifi-minifi-cpp/pull/610#discussion_r302968381
##########
File path: extensions/http-curl/client/HTTPClient.cpp
##########
@@ -265,36 +324,6 @@ bool HTTPClient::submit() {
}
logger_->log_debug("Finished with %s", url_);
- std::string key = "";
Review comment:
This logic was partial, standard non-compliant and buggy. (The concrete
issue was that it included extra \r\n's in the last header value, but there are
more problems with it). See the reimplementation below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
