YolandaMDavis commented on a change in pull request #3576: NIFI-6417 
Configurable Jolt Transform Charsets
URL: https://github.com/apache/nifi/pull/3576#discussion_r302989971
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoltTransformJSON.java
 ##########
 @@ -140,6 +141,27 @@
             .defaultValue("false")
             .build();
 
+    public static final PropertyDescriptor INPUT_CHARSET = new 
PropertyDescriptor.Builder()
+            .name("input-charset")
+            .displayName("Input Character Set")
+            .description("The encoding character set for the input JSON for 
transformation")
+            .required(true)
+            .allowableValues(StandardCharsets.UTF_8.name(), 
StandardCharsets.UTF_16.name(),
 
 Review comment:
   Will allowable charset options be the same for input/output properties?  If 
so perhaps this could be a list shared between the two for simplicity (I 
believe the builder makes internal copies of the values anyway for the property 
descriptor instance).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to