YolandaMDavis commented on a change in pull request #3576: NIFI-6417 
Configurable Jolt Transform Charsets
URL: https://github.com/apache/nifi/pull/3576#discussion_r302994925
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoltTransformJSON.java
 ##########
 @@ -266,7 +294,7 @@ public void onTrigger(final ProcessContext context, 
ProcessSession session) thro
         try (final InputStream in = session.read(original)) {
             inputJson = JsonUtils.jsonToObject(in);
 
 Review comment:
   This is where I'm wondering inputCharset was supposed to be applied for 
incoming json data (@mattyb149  any thoughts on this?)?  If so I think you may 
need a bit more manipulation to apply inputChartset before passing to 
jsonToObject (since it may not support passing inputstream with charset).  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to