arpadboda commented on a change in pull request #613: Minificpp 927 Nanofi tailfile delimited processor URL: https://github.com/apache/nifi-minifi-cpp/pull/613#discussion_r304292469
########## File path: nanofi/src/core/file_utils.c ########## @@ -0,0 +1,138 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include <stdlib.h> +#include <stdio.h> +#include <string.h> +#include <errno.h> +#include <sys/stat.h> +#include <dirent.h> +#include <unistd.h> + +#include "core/string_utils.h" +#include "core/file_utils.h" + +int is_directory(const char * path) { + struct stat dir_stat; + if (stat(path, &dir_stat) < 0) { + return 0; + } + return S_ISDIR(dir_stat.st_mode); +} + +char * get_separator(int force_posix) +{ + char * sep = malloc(2 * sizeof(char)); + strcpy(sep, "/"); +#ifdef WIN32 + if (force_posix) { + return sep; + } else { + char * sep = malloc(2 * sizeof(char)); Review comment: I doesn't really make sense for me to reallocate const strings every time this is called, not to mention the fact that it shadows the previous declaration, which results in a leak. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
