arpadboda commented on a change in pull request #613: Minificpp 927 Nanofi tailfile delimited processor URL: https://github.com/apache/nifi-minifi-cpp/pull/613#discussion_r304284767
########## File path: nanofi/ecu/log_aggregator.c ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +*/ + +#include "api/nanofi.h" +#include "api/ecu.h" +#include "core/string_utils.h" +#include "core/cstructs.h" +#include "core/file_utils.h" +#include "core/flowfiles.h" + +#include <unistd.h> +#include <stdlib.h> +#include <stdio.h> +#include <string.h> +#include <errno.h> +#include <limits.h> +#include <signal.h> +#include <sys/stat.h> + +int main(int argc, char** argv) { + + if (argc < 6) { + printf("Error: must run ./log_aggregator <file> <interval> <delimiter> <nifi instance url> <remote port>\n"); + exit(1); + } + + char * file = argv[1]; + char * interval = argv[2]; + char * delimiter = argv[3]; + char * instance_str = argv[4]; + char * port_str = argv[5]; + + if (access(file, F_OK) == -1) { + printf("Error: %s doesn't exist!\n", file); + exit(1); + } + + struct stat stats; + int ret = stat(file, &stats); + + if (ret == -1) { + printf("Error occurred while getting file status {file: %s, error: %s}\n", file, strerror(errno)); + exit(1); + } + // Check for file existence + if (S_ISDIR(stats.st_mode)){ + printf("Error: %s is a directory!\n", file); + exit(1); + } + + errno = 0; + unsigned long intrvl = strtol(interval, NULL, 10); + + if (errno == ERANGE || intrvl == LONG_MAX || intrvl == LONG_MIN) { Review comment: ``` If no valid conversion could be performed, a zero value is returned (0L). If the value read is out of the range of representable values by a long int, the function returns LONG_MAX or LONG_MIN (defined in <climits>), and errno is set to ERANGE. ``` The first condition should be AND here, LONG_MAX and LONG_MIN are valid values. As the long term goal is to make Nanofi work on Win please avoid using long (which is 32 bits on Win and 64 on Unix) Although I'm afraid negative values doesn't make sense here as intrvl is used as an argument of sleep calls. Which expect unsigned int by the way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
