phrocker commented on a change in pull request #612: MINIFICPP-854: Capture
RTSP Frame
URL: https://github.com/apache/nifi-minifi-cpp/pull/612#discussion_r304407891
##########
File path: extensions/opencv/CaptureRTSPFrame.cpp
##########
@@ -73,6 +73,11 @@ void CaptureRTSPFrame::initialize() {
relationships.insert(Success);
relationships.insert(Failure);
setSupportedRelationships(std::move(relationships));
+ // By default in OpenCV, ffmpeg capture is hardcoded to use TCP and this is
a workaround
+ // also if UDP timeout, ffmpeg will retry with TCP
+ // Note:
+ // 1. OpenCV community are trying to find a better approach than setenv.
+ setenv("OPENCV_FFMPEG_CAPTURE_OPTIONS", "rtsp_transport;udp", 1);
Review comment:
Since this is an env option why not leave it in the operating system
environment ( esp since this isn't cross platform compatible ). Can add
something to minifi.sh . I have a feeling at some point we will have OPTS set
via the conf dir that minifi.sh pulls and adds to a running instance.
@bakaid this may be a case for using the Initializer construct you added if
the shell script doesn't make sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
