phrocker commented on a change in pull request #612: MINIFICPP-854: Capture
RTSP Frame
URL: https://github.com/apache/nifi-minifi-cpp/pull/612#discussion_r304447241
##########
File path: extensions/opencv/CaptureRTSPFrame.cpp
##########
@@ -73,6 +73,11 @@ void CaptureRTSPFrame::initialize() {
relationships.insert(Success);
relationships.insert(Failure);
setSupportedRelationships(std::move(relationships));
+ // By default in OpenCV, ffmpeg capture is hardcoded to use TCP and this is
a workaround
+ // also if UDP timeout, ffmpeg will retry with TCP
+ // Note:
+ // 1. OpenCV community are trying to find a better approach than setenv.
+ setenv("OPENCV_FFMPEG_CAPTURE_OPTIONS", "rtsp_transport;udp", 1);
Review comment:
Instructions guide toward minifi.sh so that is the officially supported
solution. I'll take a look at the factory initializer a little later. If there
is a reason it can't be done in the shell scripts then I'm +0 to the
initializer, otherwise I'm a -1 to it ( since we're setting environment
variables )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
