turcsanyip commented on a change in pull request #3504: NIFI-6318: Support EL
in CSV formatting properties
URL: https://github.com/apache/nifi/pull/3504#discussion_r304804335
##########
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/csv/CSVValidators.java
##########
@@ -88,22 +89,16 @@ public ValidationResult validate(final String subject,
final String input, final
.build();
}
- String unescapeString = unescapeString(input);
+ String unescaped = CSVUtils.unescapeJava(input);
return new ValidationResult.Builder()
.subject(subject)
- .input(unescapeString)
+ .input(unescaped)
.explanation("Only non-null single characters are
supported")
- .valid((unescapeString.length() == 1 &&
unescapeString.charAt(0) != 0) || context.isExpressionLanguagePresent(input))
+ .valid((unescaped.length() == 1 && unescaped.charAt(0) !=
0)
+ || context.isExpressionLanguageSupported(subject)
&& context.isExpressionLanguagePresent(input))
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
