turcsanyip commented on a change in pull request #3504: NIFI-6318: Support EL
in CSV formatting properties
URL: https://github.com/apache/nifi/pull/3504#discussion_r304805841
##########
File path:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVReader.java
##########
@@ -108,23 +106,14 @@
}
@OnEnabled
- public void storeCsvFormat(final ConfigurationContext context) {
+ public void storeStaticProperties(final ConfigurationContext context) {
+ this.context = context;
+
this.csvParser = context.getProperty(CSV_PARSER).getValue();
- this.csvFormat = CSVUtils.createCSVFormat(context);
Review comment:
I ran some performance tests, but I could not measure any significant
difference.
Just for sure, I changed the implementation to create a static CSV format in
case no property uses EL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
