[
https://issues.apache.org/jira/browse/MINIFICPP-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889139#comment-16889139
]
Mr TheSegfault commented on MINIFICPP-984:
------------------------------------------
[~bakaid] yeah I don't think I realized this up front on review, either,....
but like I said we took a step forward, so this is a minor thing It's
noticeable in some test flows that I run for testing – but I didn't run those
when reviewing.
I'm sorry for the rather hastily written ticket ( I was also distracted by a
meeting ) – I meant "detect text output via EL," Meaning let a flag, based on
an expression, determine if we should print as hex or ASCII – I don't know if
that's smart or makes sense – just throwing that out there. My description and
title contradicted each other – that is an impressive feat, even for me.
While I don't like 80, here ( makes reading longer text difficult IMO ), I know
if at least one person who writes tests that rely on log output of a docker
container so I don't want that to be a breaking change for them or anyone else.
Good point. I was hoping to piggy back that onto this ( again on a hastily
written ticket ) – so I removed that from the description.
> LogAttribute should return to prior behavior or detect text and print it out
> ----------------------------------------------------------------------------
>
> Key: MINIFICPP-984
> URL: https://issues.apache.org/jira/browse/MINIFICPP-984
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Mr TheSegfault
> Assignee: Daniel Bakai
> Priority: Blocker
>
> Noticed by user: change in behavior on log attribute payload log.
> Prior behavior on text files printed text. In some cases this may have
> issues. I think we took a step forward; however, we should provide hex
> printing along with ascii ( leaving what was default previously as the
> default ) to be backwards compatible and provide the benefits of hex encoding
> ( maybe make it EL based, so it can be per ff )
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
