[ 
https://issues.apache.org/jira/browse/MINIFICPP-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889197#comment-16889197
 ] 

Arpad Boda commented on MINIFICPP-984:
--------------------------------------

[~phrocker] [~bakaid]:

Guys, I like the idea, let me suggest considering the way it's done in NiFi:

[https://nifi.apache.org/docs/nifi-docs/components/org.apache.nifi/nifi-standard-nar/1.6.0/org.apache.nifi.processors.standard.LogAttribute/]

So user can provide charset as a parameter, supporting EL as [~phrocker] 
suggested, we can avoid implementing detection in this case.

For the length, I think we can also introduce a parameter with a default value 
that avoids breaking changes. Not a big change, but at least gives space the 
user to configure according to his preferences. 

> LogAttribute should return to prior behavior or detect text and print it out
> ----------------------------------------------------------------------------
>
>                 Key: MINIFICPP-984
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-984
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: Mr TheSegfault
>            Assignee: Daniel Bakai
>            Priority: Blocker
>
> Noticed by user: change in behavior on log attribute payload log.
> Prior behavior on text files printed text. In some cases this may have 
> issues.  I think we took a step forward; however, we should provide hex 
> printing along with ascii ( leaving what was default previously as the 
> default ) to be backwards compatible and provide the benefits of hex encoding 
> ( maybe make it EL based, so it can be per ff )



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to