tpalfy commented on a change in pull request #3612: NIFI-6486 Add option to use
built-in retry mechanism in AWS processors
URL: https://github.com/apache/nifi/pull/3612#discussion_r310962824
##########
File path:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSProcessor.java
##########
@@ -214,7 +302,9 @@ protected static AllowableValue createAllowableValue(final
Regions region) {
protected ClientConfiguration createConfiguration(final ProcessContext
context) {
final ClientConfiguration config = new ClientConfiguration();
config.setMaxConnections(context.getMaxConcurrentTasks());
- config.setMaxErrorRetry(0);
+ PropertyValue property = context.getProperty(AWS_MAX_ERROR_RETRY);
+ config.setMaxErrorRetry(property.isSet()? property.asInteger() : 0);
Review comment:
Could be `config.setMaxErrorRetry(getMaxErrorRetry(context));`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services