tpalfy commented on a change in pull request #3612: NIFI-6486 Add option to use
built-in retry mechanism in AWS processors
URL: https://github.com/apache/nifi/pull/3612#discussion_r319975507
##########
File path:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/DeleteDynamoDB.java
##########
@@ -75,7 +75,9 @@
Arrays.asList(TABLE, HASH_KEY_NAME, RANGE_KEY_NAME,
HASH_KEY_VALUE, RANGE_KEY_VALUE,
HASH_KEY_VALUE_TYPE, RANGE_KEY_VALUE_TYPE, BATCH_SIZE, REGION,
ACCESS_KEY, SECRET_KEY,
CREDENTIALS_FILE, AWS_CREDENTIALS_PROVIDER_SERVICE, TIMEOUT,
SSL_CONTEXT_SERVICE,
- PROXY_CONFIGURATION_SERVICE, PROXY_HOST, PROXY_HOST_PORT,
PROXY_USERNAME, PROXY_PASSWORD));
+ PROXY_CONFIGURATION_SERVICE, PROXY_HOST, PROXY_HOST_PORT,
PROXY_USERNAME, PROXY_PASSWORD,
Review comment:
Since we need to change all concrete subclasses of the
`AbstractAWSProcessor`, can't we gather the property descriptors defined in it
at one place and use that instead of updating this list for each one of them.
I see that the `...DynamoDB` processors don't have the `ENDPOINT_OVERRIDE`
included.
Is that intentional or a nice example of why a common gathering logic would
be useful?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
