arpadboda commented on a change in pull request #627: MINIFICPP-989 - Motion detect for a set of captured frames URL: https://github.com/apache/nifi-minifi-cpp/pull/627#discussion_r314229446
########## File path: extensions/opencv/FrameIO.h ########## @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef NIFI_MINIFI_CPP_FRAMEIO_H +#define NIFI_MINIFI_CPP_FRAMEIO_H + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace processors { Review comment: As these are only callbacks used for opencv, could you add them to a dirrent namepsace? Opencv is fine imho. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
