dbkegley commented on a change in pull request #3651: NIFI-6539 Nifi stateless 
init from flow xml
URL: https://github.com/apache/nifi/pull/3651#discussion_r314890195
 
 

 ##########
 File path: 
nifi-stateless/nifi-stateless-core/src/main/java/org/apache/nifi/stateless/core/StatelessFlow.java
 ##########
 @@ -99,6 +122,194 @@ public StatelessFlow(final List<StatelessComponent> 
roots) {
         this.componentFactory = null;
     }
 
+    public StatelessFlow(final ProcessGroupDTO flow, final ExtensionManager 
extensionManager, final VariableRegistry variableRegistry, final List<String> 
failureOutputPorts,
 
 Review comment:
   I'm not sure how I should approach this one. I started with using the 
strategy pattern to get around the sleight differences between `Versioned*` 
objects and `*DTO` objects but I feel like I ended up with too many generics 
for what I'm trying to achieve. Do you have any recommendations for how to 
refactor this? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to