dbkegley commented on a change in pull request #3651: NIFI-6539 Nifi stateless
init from flow xml
URL: https://github.com/apache/nifi/pull/3651#discussion_r314430423
##########
File path:
nifi-stateless/nifi-stateless-core/src/main/java/org/apache/nifi/stateless/core/ComponentFactory.java
##########
@@ -120,6 +124,74 @@ public StatelessProcessorWrapper createProcessor(final
VersionedProcessor versio
}
}
+ public StatelessProcessorWrapper createProcessor(final ProcessorDTO
processorDto, final boolean materializeContent, final
StatelessControllerServiceLookup controllerServiceLookup,
Review comment:
Totally agree about all the code duplication. I was wary about it when I
submitted the PR but this is my first contribution to NiFi and I didn't know
what the appetite would be for significant code changes to an existing feature.
And tbh I'm not much of a java guy anyway so thanks for the pointers on how to
clean this up.
I've brought in your suggestions, the only thing I modified is to remove the
generic for the private methods as I don't think they're needed since we
already extracted the params we needed and intellij was complaining
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
