scottyaslan commented on a change in pull request #3683: NIFI-6506 - Add
ability to convert properties to parameters
URL: https://github.com/apache/nifi/pull/3683#discussion_r320483558
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##########
@@ -814,12 +814,23 @@
*/
var serializeParameter = function (originalParameter) {
var name = $.trim($('#parameter-name').val());
+ var value = $('#parameter-value-field').val();
var isEmptyStringSet =
$('#parameter-set-empty-string-field').hasClass('checkbox-checked');
-
- var serializedValue = serializeValue($('#parameter-value-field'),
originalParameter, isEmptyStringSet);
var description = $('#parameter-description-field').val();
var isSensitive =
$('#parameter-dialog').find('input[name="sensitive"]:checked').val() ===
'sensitive' ? true : false;
+ var parameter = {
+ name: name,
+ value: value,
+ description: description,
+ sensitive: isSensitive,
+ isEmptyStringSet: isEmptyStringSet,
+ previousValue: null,
+ isNew: true
+ };
+
+ var serializedValue = serializeValue($('#parameter-value-field'),
_.isNil(originalParameter) ? parameter : originalParameter, isEmptyStringSet);
+
return {
Review comment:
The serializedParam you are returning here could also have a
'hasDescriptionChanged: description !== originalParameter.description'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
