scottyaslan commented on a change in pull request #3683: NIFI-6506 - Add
ability to convert properties to parameters
URL: https://github.com/apache/nifi/pull/3683#discussion_r320488673
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##########
@@ -1042,10 +1032,11 @@
text: '#ffffff'
},
disabled: function () {
- if ($('#parameter-context-name').val() !== '') {
- return false;
+ var param = serializeParameter();
Review comment:
I don't think you meant to do this here... This is the parameter context
dialog not the parameter dialog. The only requirement to create a parameter
context is a name... I know we have
https://issues.apache.org/jira/browse/NIFI-6602 open and I am thinking we may
need to create a `serializeParameterContext()` so we could then ask the
returned object about it's name or if there are any parameters to update... but
for this PR you probably just need to make sure there is a value in the
`$('#parameter-context-name')` field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
